zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the `sample table`
design by `get sample from source table`(in the other words, it isn't for a
specific query, instead, answer: what data/schema is in the source table) so we
should do through query every time. (Breakthrough cache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
