zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r769459326
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
The key problem to solve here is that when the schema of table changed,
we don't have a chance to refresh the sample cache. (the Superset isn't chance
to get changes from the database)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
