zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r772406898
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
Thanks for the reminder! I think we need to make a tradeoff. BTW, there
is a setting item: `SAMPLES_ROW_LIMIT = 1000` in config.py that how many sample
rows will return.
What do you think about this issue? @evans @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
