graceguo-supercat commented on pull request #17751: URL: https://github.com/apache/superset/pull/17751#issuecomment-994109174
Server-side has validation, front-end doesn't really need to do extra validation, no matter its decimal or letter. `why let the user type in something invalid at all`? why not? I am ok to let user type in whatever they want, server-side will prevent bad data get into database. As a Superset user come to Alert setting page, i assume he /she will type in values with his/her common sense. When error / exception showing up, he/she will check tooltip and adjust his/her behavior after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org