ktmud commented on pull request #17751: URL: https://github.com/apache/superset/pull/17751#issuecomment-994987967
Why do we have such a server side restriction in the first place? It feels like here at least floats should be allowed, too. It's very common to set up alerts on percent/ratio metrics, etc. Can we maybe just change the [server side validation](https://github.com/apache/superset/blob/f10bc6d8fe7f3fa4056db2aaff8256f9c3e1550b/superset/reports/schemas.py#L106) to `fields.Float()`? It's a JSON field so no db migration is needed. cc @dpgaspar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
