etr2460 commented on pull request #17751:
URL: https://github.com/apache/superset/pull/17751#issuecomment-995226449
>your suggestion is, user type in 3.5, Superset secretly truncate to 3 and
save into backend without user notice?
nope, that handler sets the value in state and then renders it to the input
(because it's a controlled component). The effect of this change would be that
pressing the period key would put nothing in the input, and pasting a decimal
string would truncate to everything before the decimal:
```
<input
type="number"
name="threshold"
disabled={conditionNotNull}
value={
currentAlert &&
currentAlert.validator_config_json &&
currentAlert.validator_config_json.threshold !==
undefined
? currentAlert.validator_config_json.threshold
: ''
}
placeholder={t('Value')}
onChange={onThresholdChange}
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
