graceguo-supercat edited a comment on pull request #17751: URL: https://github.com/apache/superset/pull/17751#issuecomment-995221403
to @etr2460: your suggestion is, user type in 3.5, Superset secretly truncate to 3 and save into backend without user notice? User still believe Superset accept decimal but actually not? 😳 I think this behavior is even worse than throw exception. to @ktmud: `fields.Float()` was part of my plan, but it raises another question is what is precision? what if user type in something like `3.1415926535 8979323846 2643383279 5028841971 6939937510 5820974944 5923078164 0628620899 8628034825 3421170679`. We still need to let user know the limit (we can add it in the tooltip). If the extra precision is needed, user still need to handle it like user handles integer. But handling short float is a pretty common use case. I think add front-end input validation just for this input field is very random and not necessary. For Superset, site-wide consistent front-end validation behavior is probably more desirable for chart controls, etc. If in the near future, Superset has plan for explore view, like consistent chart controls or similar features, this validation framework is a good candidate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
