eschutho commented on a change in pull request #18131:
URL: https://github.com/apache/superset/pull/18131#discussion_r806343673
##########
File path:
superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.tsx
##########
@@ -147,61 +135,61 @@ export default function HeaderReportActionsDropDown({
</Menu.Item>
</Menu>
);
-
return (
- canAddReports() && (
- <>
- <ReportModal
- userId={user.userId}
- showModal={showModal}
- onHide={() => setShowModal(false)}
- userEmail={user.email}
- dashboardId={dashboardId}
- chart={chart}
- />
- {report ? (
- <>
- <NoAnimationDropdown
- // ref={ref}
- overlay={menu()}
- trigger={['click']}
- getPopupContainer={(triggerNode: any) =>
- triggerNode.closest('.action-button')
- }
+ <>
+ {canAddReports() && (
Review comment:
since this is a functional component we can probably make this a prop
instead of a method. We can fix this on the merge to master PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
