eschutho commented on a change in pull request #18131:
URL: https://github.com/apache/superset/pull/18131#discussion_r806345294
##########
File path: superset-frontend/src/components/ReportModal/index.tsx
##########
@@ -307,6 +283,13 @@ const ReportModal: FunctionComponent<ReportProps> = ({
</>
);
+ const renderErrorMessage = () => {
+ if (currentReport?.error) {
+ return errorMapping[currentReport.error] || currentReport?.error;
+ }
+ return currentReport?.error;
Review comment:
if 287 is false, would this also be falsy/null/undefined? Should we just
return nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
