kgabryje commented on a change in pull request #18784:
URL: https://github.com/apache/superset/pull/18784#discussion_r809269445
##########
File path: superset-frontend/src/components/Button/index.tsx
##########
@@ -200,14 +200,16 @@ export default function Button(props: ButtonProps) {
},
'&[disabled], &[disabled]:hover': {
color: grayscale.base,
- backgroundColor: backgroundColorDisabled,
- borderColor: borderColorDisabled,
+ backgroundColor:
+ buttonStyle === 'link' ? 'transparent' : backgroundColorDisabled,
+ borderColor:
+ buttonStyle === 'link' ? 'transparent' : borderColorDisabled,
},
marginLeft: 0,
'& + .superset-button': {
marginLeft: theme.gridUnit * 2,
},
- '& :first-of-type': {
+ '& > :first-of-type': {
Review comment:
This selector was targeting every "first of type" element being a
descendant of `Button`. In this case (see screenshot below), it would target
both `<span>` and `<svg>` elements, so in result we'd apply margin twice. With
this change, we'll only target direct children of `Button`.
<img width="549" alt="image"
src="https://user-images.githubusercontent.com/15073128/154531575-e15b41c3-4c69-4c0a-877f-7f3f38a4c527.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/154531575-e15b41c3-4c69-4c0a-877f-7f3f38a4c527.png"](https://user-images.githubusercontent.com/15073128/154531575-e15b41c3-4c69-4c0a-877f-7f3f38a4c527.png"){kind=link}