michael-s-molina commented on a change in pull request #18784:
URL: https://github.com/apache/superset/pull/18784#discussion_r809250446
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
##########
@@ -126,29 +87,18 @@ const Header: FC<HeaderProps> = ({
<Icons.Expand iconColor={theme.colors.grayscale.base} />
</HeaderButton>
</TitleArea>
- <ActionButtons className="filter-action-buttons">
- <Button
- disabled={isClearAllDisabled}
- buttonStyle="tertiary"
- buttonSize="small"
- className="filter-clear-all-button"
- onClick={onClearAll}
- {...getFilterBarTestId('clear-button')}
- >
- {t('Clear all')}
- </Button>
- <Button
- disabled={isApplyDisabled}
- buttonStyle="primary"
- htmlType="submit"
- buttonSize="small"
- className="filter-apply-button"
- onClick={onApply}
- {...getFilterBarTestId('apply-button')}
- >
- {t('Apply')}
- </Button>
- </ActionButtons>
+ {canEdit && (
+ <AddFiltersButtonContainer>
+ <FilterConfigurationLink
+ dashboardId={dashboardId}
+ createNewOnOpen={filterValues.length === 0}
+ >
+ <>
Review comment:
I noticed that the plus icon is not vertically aligned with the text.
Can we fix it? Is the fragment necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
