michael-s-molina edited a comment on pull request #18784: URL: https://github.com/apache/superset/pull/18784#issuecomment-1043133087
@kgabryje Did you test it with the white background instead of the semi-transparent one? For me, when a filter is passing behind the buttons it looks really weird like the layout broke or something. <img width="268" alt="Screen Shot 2022-02-17 at 1 44 49 PM" src="https://user-images.githubusercontent.com/70410625/154529273-478c1535-e300-40e9-a52e-8f8af069ef5e.png"> I think keeping a white background with the buttons outside of the scrollable area is also consistent with the top buttons. https://user-images.githubusercontent.com/70410625/154530268-2eac1d2f-a01f-4306-83c5-a47a9ed66eee.mov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
