kgabryje commented on a change in pull request #18784:
URL: https://github.com/apache/superset/pull/18784#discussion_r809894430
##########
File path: superset-frontend/src/components/Button/index.tsx
##########
@@ -200,14 +200,16 @@ export default function Button(props: ButtonProps) {
},
'&[disabled], &[disabled]:hover': {
color: grayscale.base,
- backgroundColor: backgroundColorDisabled,
- borderColor: borderColorDisabled,
+ backgroundColor:
+ buttonStyle === 'link' ? 'transparent' : backgroundColorDisabled,
+ borderColor:
+ buttonStyle === 'link' ? 'transparent' : borderColorDisabled,
},
marginLeft: 0,
'& + .superset-button': {
marginLeft: theme.gridUnit * 2,
},
- '& :first-of-type': {
+ '& > :first-of-type': {
Review comment:
I did a quick audit of use cases of button with icon + text. In most
cases we use icons from `fa`, which don't have multi-level structure like antd
icons. We use button with antd icon in SqlLab, however in that case the margin
is manually overriden to 0. Of course, it's very likely that I missed some use
cases, but I don't think that applying margin to every `first-of-type` element
in button tree is expected behaviour, so it's worth to fix it anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
