kgabryje commented on pull request #18784: URL: https://github.com/apache/superset/pull/18784#issuecomment-1044715948
Thanks for comments @geido! 1. I'd propose a compromise - I can change the background gradient from full white at 50% of container height to 25%. Here's how it looks: https://user-images.githubusercontent.com/15073128/154713009-aa89d96c-eba5-476f-97be-425d7936b2b3.mov CC @kasiazjc 2. That's quite problematic... The whole FilterBar container is jumping, because we change it's height in javascript when user scrolls past the top menu (see how `filterBarHeight` is calculated in `DashboardBuilder.tsx`). @michael-s-molina I see that this piece of cde was written by you - do you have any suggestion on have we can improve it so that scrolling is smoother? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
