kgabryje commented on a change in pull request #18784:
URL: https://github.com/apache/superset/pull/18784#discussion_r809897518
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
##########
@@ -126,29 +87,18 @@ const Header: FC<HeaderProps> = ({
<Icons.Expand iconColor={theme.colors.grayscale.base} />
</HeaderButton>
</TitleArea>
- <ActionButtons className="filter-action-buttons">
- <Button
- disabled={isClearAllDisabled}
- buttonStyle="tertiary"
- buttonSize="small"
- className="filter-clear-all-button"
- onClick={onClearAll}
- {...getFilterBarTestId('clear-button')}
- >
- {t('Clear all')}
- </Button>
- <Button
- disabled={isApplyDisabled}
- buttonStyle="primary"
- htmlType="submit"
- buttonSize="small"
- className="filter-apply-button"
- onClick={onApply}
- {...getFilterBarTestId('apply-button')}
- >
- {t('Apply')}
- </Button>
- </ActionButtons>
+ {canEdit && (
+ <AddFiltersButtonContainer>
+ <FilterConfigurationLink
+ dashboardId={dashboardId}
+ createNewOnOpen={filterValues.length === 0}
+ >
+ <>
Review comment:
It actually was vertically aligned, but it looked as if it wasn't... I
added a 1px bottom padding and it looks better now
<img width="438" alt="image"
src="https://user-images.githubusercontent.com/15073128/154670472-d5da8dbd-d607-4c71-afa0-8d4d45b418aa.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/154670472-d5da8dbd-d607-4c71-afa0-8d4d45b418aa.png"](https://user-images.githubusercontent.com/15073128/154670472-d5da8dbd-d607-4c71-afa0-8d4d45b418aa.png"){kind=link}