villebro commented on PR #19558: URL: https://github.com/apache/superset/pull/19558#issuecomment-1092626293
Three observations: 1) Currently the Run button only becomes "enabled" (well, it's not really ever disabled, the background just becomes white) when the query result is stale from controls that affect the queries (see before video). In the new version, the "Update chart" button is "enabled" all the time (see after video). 2) The "Run Query" in the chart container should probably be changed to "Update chart" to be in line with the other button. 3) When there are errors, currently the Save button is disabled. In the new version, the Save button appears to be enabled all the time. A more general observation: I believe one of the reasons the button is currently called "Run" is to reflect that it executes a query (changing controls that only affect the visuals of the chart don't require rerunning the chart, as they're applied on the fly). Renaming it to "Create chart" and "Update chart" *may* cause confusing due to the following: - Users will think they have to press "Update chart" when they make changes that don't affect the query - When the button is called "Create chart", there's risk that users will think it will also save the chart. However, my comments should be taken with a grain of salt, as I'm probably too used to the old behavior. Other than that I love the new design! Before: https://user-images.githubusercontent.com/33317356/162401526-5282bf89-9d89-4022-8c84-e96119de0628.mp4 After: https://user-images.githubusercontent.com/33317356/162401608-33ebbb17-6ccc-47ea-80c7-2e633ae9bf0e.mp4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
