kgabryje commented on PR #19558: URL: https://github.com/apache/superset/pull/19558#issuecomment-1092634093
> 1. Currently the Run button only becomes "enabled" (well, it's not really ever disabled, the background just becomes white) when the query result is stale from controls that affect the queries (see before video). In the new version, the "Update chart" button is "enabled" all the time (see after video). Good point, will change! > 2. The "Run Query" in the chart container should probably be changed to "Update chart" to be in line with the other button. Today I'm going to open a PR that totally removes the overlay with "Run query". It will be replaced by an alert banner that tells the user that something has changed in the controls. Thanks to that, the user will still be able to see the chart while making changes in the controls. > 3. When there are errors, currently the Save button is disabled. In the new version, the Save button appears to be enabled all the time. Oooooops... > A more general observation: I believe one of the reasons the button is currently called "Run" is to reflect that it executes a query (changing controls that only affect the visuals of the chart don't require rerunning the chart, as they're applied on the fly). Renaming it to "Create chart" and "Update chart" _may_ cause confusing due to the following: > > * Users will think they have to press "Update chart" when they make changes that don't affect the query > * When the button is called "Create chart", there's risk that users will think it will also save the chart. I'll let @kasiazjc address that one 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
