michael-s-molina commented on PR #19558: URL: https://github.com/apache/superset/pull/19558#issuecomment-1093009369
> Users will think they have to press "Update chart" when they make changes that don't affect the query I agree with @villebro on this one I really like the new design, things are getting less cluttered, and the Explore screen seems simpler while keeping the same features. I do have a different preference for the organization for the create/update buttons though. I personally don't like things floating on top of other things, especially on top of the configuration panel where we have many controls. It gives me a crowded feeling. One idea would be to move the create button directly below the empty message, it seems very intuitive because I'm reading that my chart is ready to go and there would be a button right there to create it. About the update, I liked the previous version that showed an overlay on top of the chart with a button to update. I like this approach because: - It shows the user (with the overlay + button) that they did a configuration that needs an explicit update request - The button to update is right there on the overlay. We could even add a message indicating that the user needs to update to see the changes reflected on the chart - When a user does a configuration on the left panel that doesn't require an explicit update request, the chart simply updates and there's no button on the screen that could lead to confusion. For the case where the user wants to re-execute the query without having made any modification to the configurations, to bust the cache, for example, we could have a "Refresh data" option in the secondary actions popover. These are just ideas, I don't consider them as blockers for the PR in case you choose a different direction 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
