diegomedina248 commented on code in PR #19960:
URL: https://github.com/apache/superset/pull/19960#discussion_r866266988
##########
superset-frontend/src/dashboard/components/gridComponents/Chart.jsx:
##########
@@ -154,6 +157,10 @@ export default class Chart extends React.Component {
return true;
}
+ if (!isEqual(nextProps.chart, this.props.chart)) {
Review Comment:
is this different than `if (!areObjectsEqual(nextProps[prop],
this.props[prop]))`?
If you don't filter the chart prop to `SHOULD_UPDATE_ON_PROP_CHANGES`,
shouldn't the code reach the `areObjectEquals`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
