diegomedina248 commented on code in PR #19960:
URL: https://github.com/apache/superset/pull/19960#discussion_r866277210
##########
superset-frontend/src/dashboard/components/gridComponents/Chart.jsx:
##########
@@ -154,6 +157,10 @@ export default class Chart extends React.Component {
return true;
}
+ if (!isEqual(nextProps.chart, this.props.chart)) {
Review Comment:
mm, but I think `isComponentVisible` might be broader, and put in place for
a reason.
If we add this condition here, we might be triggering more rerenders than
expected.
@rusackas what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
