prosdev0107 commented on code in PR #19960:
URL: https://github.com/apache/superset/pull/19960#discussion_r866275411
##########
superset-frontend/src/dashboard/components/gridComponents/Chart.jsx:
##########
@@ -154,6 +157,10 @@ export default class Chart extends React.Component {
return true;
}
+ if (!isEqual(nextProps.chart, this.props.chart)) {
Review Comment:
@diegomedina248
I think that `isEqual` works similar to `areObjectsEqual` and
`areObjectsEqual` maybe more strict in this case.
And then, when click `refresh dashboard` after change the dataset, all chart
components should update whether if it is now visible or not. Thus, I define
the filtering by chart props outside of `isComponentVisible` props filtering
and so `chart` prop doesn't need to reach the `areObjectEquals` in
`SHOULD_UPDATE_ON_PROP_CHANGES `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
