kgabryje opened a new pull request, #19993: URL: https://github.com/apache/superset/pull/19993
### SUMMARY This PR adds a browser confirmation modal (similar to the one that we have in dashboard edit mode) when user makes a change in control panel and then tries to close Explore (either by closing the tab or moving to another page) without clicking Save button. Currently, that modal is not customizable. However, when we implement Single Page Application in Superset, we'll probably be able to customize the modal when navigating within Superset. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/167422541-da6709f4-605b-4740-8cb5-80f693b956ea.png";> ### TESTING INSTRUCTIONS 1. Open a chart 2. Make some changes in control panel 3. Try to leave the page (close tab or navigate to another page) 4. Verify that browser confirmation modal appears 1. Open a chart 2. Make some changes in control panel and save. 3. Leave the page, verify that the modal didn't appear 1. Open a chart 2. Make some changes in control panel. 3. Revert those changes (for example add and remove a metric) 4. Leave the page, verify that the modal didn't appear ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/167422541-da6709f4-605b-4740-8cb5-80f693b956ea.png"](https://user-images.githubusercontent.com/15073128/167422541-da6709f4-605b-4740-8cb5-80f693b956ea.png"){kind=link}