kgabryje commented on PR #19993: URL: https://github.com/apache/superset/pull/19993#issuecomment-1123710841
> Found two more problems: 1 - It's showing the confirmation when navigating using the main header without any changes. 2 - It's showing the confirmation when dropping a filter and canceling > > Screen.Recording.2022-05-11.at.8.47.13.AM.mov Thanks for more testing 🙂 1. It looks like the algorithm for calculating diffs for `Altered` table is faulty, because the confirmation modal uses the same logic. `Altered` pill probably shouldn't popup here as you just opened a saved chart, so the problem might be related. Will investigate. 2. I don't think it's related to dropping and cancelling filter. The `Altered` pill is visible and it's most likely that that's why the confirmation modal is showing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
