kgabryje commented on PR #19993: URL: https://github.com/apache/superset/pull/19993#issuecomment-1123723611
@michael-s-molina It looks like `sliceFormData` which was used as a reference for "initial" form data didn't include values of controls that are "trigger renders" (so mostly controls in Customize section). I fixed it by using actual initial form data instead of form data from chart. The takeaway is that in case the user does the following steps: 1. Open a chart 2. Change something in form data 3. Run query 4. Reload the page (confirmation modal appears) 5. Close the page without saving - confirmation modal doesn't appear On the other hand such flow might be expected - when user changes something in the chart and then sends a link to someone else, that other user shouldn't see the confirmation modal before closing the tab. I think that current solution is optimal, but tagging @lauderbaugh @kasiazjc @rusackas in case you guys have different opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
