michael-s-molina commented on PR #20194: URL: https://github.com/apache/superset/pull/20194#issuecomment-1144888324
@zhaoyongjie I prefer to omit the parameters here just like any other function. Especially because it's clearly typed as `PostProcessingFactory` which allows the developer to easily check the available parameters. It's the same as a `forEach` where you have access to the `element` and `index` but often the `index` is omitted because it's not used. Prettier will reformat the code the same way as it would for any other function. I don't think adding `eslint` ignores here is the way to go but curious to hear other opinions as well. @villebro @rusackas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
