zhaoyongjie commented on PR #20194: URL: https://github.com/apache/superset/pull/20194#issuecomment-1144896043
> Prettier will reformat the code the same way as it would for any other function. I don't think adding `eslint` ignores here is the way to go but curious to hear other opinions as well. How do we avoid reformat codes and increase chances? I think all of us often encounter changes to just one variable in a line, then change can become larger because of `prettier` to reformat. We should try to make these changes manageable, instead of making more and more changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
