michael-s-molina commented on PR #20194: URL: https://github.com/apache/superset/pull/20194#issuecomment-1144903410
I really like the idea of reducing unnecessary changes but I don't think it's the case here. The variables are not being used, I don't think we should keep them to avoid a bigger diff during PR reviews. In fact, if one of these operators starts to use the arguments, then I would really like to see the signature change because it will clearly show that the variable is now being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
