codyml opened a new pull request, #20369:
URL: https://github.com/apache/superset/pull/20369

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   - Update help text to be "Add a dataset or view instructions."
   - Make "Add a dataset" link to the dataset CRUD page in a new tab with the + 
Dataset modal open
     - Add support for a `#create` URL hash on the dataset CRUD page that opens 
the + Dataset modal at load
   - Make "view instructions" link to the documentation in a new tab, as before
   - Make "Choose a dataset" select element refresh its options on load so 
newly-added datasets are included
   - Update font styles and spacing on page 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   
![before](https://user-images.githubusercontent.com/13007381/173460532-9574d5e5-6bb6-4271-bad3-6e69c8f3d9d2.png)
   
   **After:**
   
![after](https://user-images.githubusercontent.com/13007381/173460562-257dc30b-8e35-4da7-96dc-221e43bada8a.png)
   
   ### TESTING INSTRUCTIONS
   - Visit `/chart/add` and open the "Choose a dataset" select.
   - Confirm that clicking "Add a dataset" opens `/tablemodelview/list` in a 
new tab with the "Add dataset" modal open.
   - Add a new dataset, switch back to the `/chart/add` tab, and confirm that 
the new dataset now appears in the "Choose a dataset" select.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to