michael-s-molina commented on PR #20369: URL: https://github.com/apache/superset/pull/20369#issuecomment-1159125704
> @michael-s-molina Re: opening the + Dataset modal via URL: I tried changing the trigger from hash `#create` to query param (`create=true`), but the table on the page clears the query params and sets its own as soon as it renders and though I didn't dig into it too deeply, it seemed like adjusting that behavior to allow my `create=true` one to survive long enough to be read would be a challenge. OK to leave it as a hash or want me to keep working on making it a query param? I think it's ok to use the hash if we consider the modal as a subordinate of the listing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
