codyml commented on PR #20369: URL: https://github.com/apache/superset/pull/20369#issuecomment-1156912697
> Can we maybe make the "Add dataset" modal reusable and open the modal directly from the "Add a dataset" link here? > > Also, it seems the current "Add a dataset" modal supports only adding a physical dataset. We should probably design a way for users to create virtual datasets here, too. That all sounds reasonable to me, but from what I can tell the [`addSlice`](https://github.com/apache/superset/tree/cb38b1fd176fc78554bf54a29458405cc43bbfd1/superset-frontend/src/addSlice) page lives in its own React tree so it might take some work to get the working modal to render there. Maybe as a separate issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
