eschutho commented on code in PR #20380:
URL: https://github.com/apache/superset/pull/20380#discussion_r897255978
##########
superset/initialization/__init__.py:
##########
@@ -473,7 +472,11 @@ def configure_data_sources(self) -> None:
# Registering sources
module_datasource_map = self.config["DEFAULT_MODULE_DS_MAP"]
module_datasource_map.update(self.config["ADDITIONAL_MODULE_DS_MAP"])
- ConnectorRegistry.register_sources(module_datasource_map)
+
+ # todo(hughhhh): fully remove the datasource config register
+ for module_name, class_names in module_datasource_map.items():
+ class_names = [str(s) for s in class_names]
+ __import__(module_name, fromlist=class_names)
Review Comment:
We should be able to remove the DEFAULT_MODULE_DS_MAP and
ADDITIONAL_MODULE_DS_MAP for SIP68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
