eschutho commented on code in PR #20380:
URL: https://github.com/apache/superset/pull/20380#discussion_r897256660
##########
superset/models/dashboard.py:
##########
@@ -407,16 +408,18 @@ def export_dashboards( # pylint: disable=too-many-locals
id_ = target.get("datasetId")
if id_ is None:
continue
- datasource =
ConnectorRegistry.get_datasource_by_id(session, id_)
+ datasource = DatasourceDAO.get_datasource(
Review Comment:
Same as above.. I don't think we need to use the DatasourceDAO if there's
only one type that will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
