eschutho commented on code in PR #20380: URL: https://github.com/apache/superset/pull/20380#discussion_r897256985
########## superset/examples/helpers.py: ########## @@ -23,16 +23,17 @@ from urllib import request from superset import app, db -from superset.connectors.connector_registry import ConnectorRegistry +from superset.datasource.dao import DatasourceDAO from superset.models.slice import Slice +from superset.utils.core import DatasourceType BASE_URL = "https://github.com/apache-superset/examples-data/blob/master/"; misc_dash_slices: Set[str] = set() # slices assembled in a 'Misc Chart' dashboard def get_table_connector_registry() -> Any: - return ConnectorRegistry.sources["table"] + return DatasourceDAO.sources[DatasourceType.TABLE] Review Comment: can we use sqlatable lookup directly instead of the DatasourceDAO since it's only one type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
