kgabryje commented on PR #20377:
URL: https://github.com/apache/superset/pull/20377#issuecomment-1156459470
> Yes, this is the current workflow. I explain it as follows:
>
> 1. line chart -> switch to big number (do **transform** from `line` to
`big number`)
> 2. big number -> switch to bar chart (do **transform** from `big number`
to `bar chart`), the `big number` has not dimensions so the `bar chart` also
has not dimensions.
> 3. if you do not do any operation on the `big number`, from `big number`
switch to the `line chart`, `standardized form data` will do **restore**, so
the line chart form_data can be restored.
>
> * the **transform** means to transform from the previous chart(Whether you
query the data or not.)
> * the **restore** means to restore to the original form_data.
>
> Right now, the Standardized Form Data doesn't provide a mechanism to
"skip" a chart when do transformation.
I see your point! I'm still a bit afraid that this flow might be confusing
for the end user who doesn't know how the feature works under the hood. I think
more intuitive flow would be to keep controls in standardized form data and
reset it only when user runs query. Like for example, if we saved dimensions in
standardized form data while on line chart, they should still be there when
user switches to big number, so they can carry over to next viz types. Only
after user runs big number query the dimensions would get reset.
That's how I think I'd expect this feature to behave if I was the end user.
Maybe we should get some input from product people? @lauderbaugh @rusackas what
do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
