zhaoyongjie commented on PR #20377: URL: https://github.com/apache/superset/pull/20377#issuecomment-1156498060
Thanks for the review. I have some different views. > I think more intuitive flow would be to keep controls in standardized form data and reset it only when user runs query. Like for example, if we saved dimensions in standardized form data while on line chart, they should still be there when user switches to big number, so they can carry over to next viz types. Only after user runs big number query the dimensions would get reset. If we discard the unqueried charts, this will affect the consistency of the analysis. for example 1. line chart -> switch to the `big number` 2. add some filters on the `big number`, but do not query. 3. switch to the `pie chart`, if we discard the `big number` form_data, the filters on the `big number` will be lost when the user switches to `the Pie chart`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
