kgabryje commented on PR #20377: URL: https://github.com/apache/superset/pull/20377#issuecomment-1156507501
> if we discard the `big number` form_data, the filters on the `big number` will be lost when the user switches to `the Pie chart`. Ah no, I don't want to discard big number form data, sorry for not writing that clearer. I only don't want to reset the controls that are not present in big number. So for example, when we set some controls in line chart, switch to big number and do some changes and then switch to pie - I don't think we should restore line chart form data. I think we should use form data of big number + use dimensions stored in stadardizedFormData.columns, which was not reset by changing viz type to big number -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
