AAfghahi commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r898120325
##########
superset-frontend/packages/superset-ui-core/test/query/extractExtras.test.ts:
##########
@@ -17,12 +17,13 @@
* under the License.
*/
import extractExtras from '../../src/query/extractExtras';
+import { TimeGranularity } from '../../src/time-format/types';
describe('extractExtras', () => {
const baseQueryFormData = {
datasource: '1__table',
granularity_sqla: 'ds',
- time_grain_sqla: 'PT1M',
+ time_grain_sqla: TimeGranularity.MINUTE,
Review Comment:
Is this one also fine for now, pending more opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
