AAfghahi commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r894720000
##########
superset-frontend/packages/superset-ui-core/src/query/extractTimegrain.ts:
##########
@@ -23,7 +23,7 @@ import { TimeGranularity } from '../time-format';
export default function extractTimegrain(
formData: QueryFormData,
-): TimeGranularity | undefined {
+): TimeGranularity | undefined | string {
Review Comment:
I am not excited about changing this to include strings, even though it
seems to be pretty 50/50 in the codebase. Is it worth to go through and
refactor the string portions @eschutho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
