eschutho commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r897349063
##########
superset-frontend/packages/superset-ui-core/test/chart/fixtures/formData.ts:
##########
@@ -19,13 +19,14 @@
/* eslint sort-keys: 'off' */
/** The form data defined here is based on default visualizations packaged
with Apache Superset */
+import { TimeGranularity } from '../../../src/time-format/types';
Review Comment:
@rusackas and @eric-briscoe and I were talking about uni-directional imports
from packages to the rest of superset-frontend but not the other direction (to
avoid circular imports). I'd say since this is just a fixture for a test that
it may be simpler to just leave the string there, but looking for other
opinions here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
