john-bodley opened a new pull request, #20492: URL: https://github.com/apache/superset/pull/20492
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This is the first PR in a slew of many to cleanup/standardize the user ID/username logic. Specifically it: 1. Replaces the Flask-AppBuilder [User.get_id](https://github.com/dpgaspar/Flask-AppBuilder/blob/090ddb4645992fb390da93906301c63b204db0df/flask_appbuilder/security/sqla/models.py#L160-L161) and Flask-Login [UserMixin.get_id](https://github.com/maxcountryman/flask-login/blob/082badd924a678445795721d67f8f6bf3f29ad58/src/flask_login/mixins.py#L23-L27) calls which returns `Optional[str]` with a `get_user_id` convenience method which returns `Optional[int]`. I'm not sure how problematic this was given I doubt authors know of this nuance and thus many Python `==` checks would have failed, i.e., `1 != "1"`, however the database filters may have been more lenient, i.e., in MySQL `SELECT 1 = '1'` evaluates to true. 2. Fixes `get_owner` which returned the ID of the current user and not the referenced user. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
