ktmud commented on code in PR #20492:
URL: https://github.com/apache/superset/pull/20492#discussion_r906244284
##########
1:
##########
@@ -0,0 +1,1527 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
Review Comment:
What's this file?
##########
superset/charts/dao.py:
##########
@@ -70,15 +71,15 @@ def overwrite(slc: Slice, commit: bool = True) -> None:
db.session.commit()
@staticmethod
- def favorited_ids(charts: List[Slice], current_user_id: int) ->
List[FavStar]:
+ def favorited_ids(charts: List[Slice]) -> List[FavStar]:
Review Comment:
Will we ever need to get a list of favorited charts for other users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
