john-bodley commented on code in PR #20492:
URL: https://github.com/apache/superset/pull/20492#discussion_r906267179
##########
superset/charts/dao.py:
##########
@@ -70,15 +71,15 @@ def overwrite(slc: Slice, commit: bool = True) -> None:
db.session.commit()
@staticmethod
- def favorited_ids(charts: List[Slice], current_user_id: int) ->
List[FavStar]:
+ def favorited_ids(charts: List[Slice]) -> List[FavStar]:
Review Comment:
@ktmud no. Also this logic is going to refactored in another PR. In general
Superset does not handle users other than the current logged in user. There
have been recent mechanisms added to override the user globally if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
