dungdm93 commented on PR #20729: URL: https://github.com/apache/superset/pull/20729#issuecomment-1192728228
@john-bodley Trino using official driver, not PyHive as Presto. This mean that a lot of function like `get_table_names`, `get_view_names`, `handle_cursor`, etc... implement naively in driver. Do u think we should change it back to `TrinoEngineSpec(BaseEngineSpec)` to avoid inherit messy code from `PrestoEngineSpec` (and prevent bugs as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
