dungdm93 commented on PR #20729: URL: https://github.com/apache/superset/pull/20729#issuecomment-1206166295
@john-bodley 2 projects are now different enough to have separated EngineSpec (at least in driver side). You just save a few line of code by let `TrinoEngineSpec` inherit messy code from `PrestoEngineSpec` (and introducing bugs). > at the moment there is a significant amount of the code that is the same The significant amount of the code you said is used to patch PyHive driver. Trino in the other hand strictly follow DB-API 2, so default implementations from `BaseEngineSpec` are good enough. Other utility functions like `estimate_statement_cost`, `query_cost_formatter` may the same. However, those func can be reused by move to an `utils.py` if u wanna do DRY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
