riahk commented on code in PR #21033:
URL: https://github.com/apache/superset/pull/21033#discussion_r942836661
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -179,7 +179,10 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
setItem(LocalStorageKeys.homepage_collapse_state, state);
};
+ const WelcomeMessageExtension = extensionsRegistry.get('welcome.message');
const WelcomeTopExtension = extensionsRegistry.get('welcome.banner');
+ const WelcomeDataExtension = extensionsRegistry.get('welcome.data');
+ const WelcomeTableExtension = extensionsRegistry.get('welcome.table');
Review Comment:
yeah it might make more sense to put the data/table into a single component
and import. the message needs to go above the banner though... should we be
renaming that one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
