samtfm commented on code in PR #21033:
URL: https://github.com/apache/superset/pull/21033#discussion_r942932915
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -179,7 +179,10 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
setItem(LocalStorageKeys.homepage_collapse_state, state);
};
+ const WelcomeMessageExtension = extensionsRegistry.get('welcome.message');
const WelcomeTopExtension = extensionsRegistry.get('welcome.banner');
+ const WelcomeDataExtension = extensionsRegistry.get('welcome.data');
+ const WelcomeTableExtension = extensionsRegistry.get('welcome.table');
Review Comment:
Could the welcome message be added to the 'welcome.banner' extension point?
(renaming extension points is _technically_ a breaking change. It's probably
fine to do at this point, but we shouldn't be considering these to be easily
renamable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
