samtfm commented on code in PR #21033:
URL: https://github.com/apache/superset/pull/21033#discussion_r943064183
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -179,7 +179,10 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
setItem(LocalStorageKeys.homepage_collapse_state, state);
};
+ const WelcomeMessageExtension = extensionsRegistry.get('welcome.message');
const WelcomeTopExtension = extensionsRegistry.get('welcome.banner');
+ const WelcomeDataExtension = extensionsRegistry.get('welcome.data');
+ const WelcomeTableExtension = extensionsRegistry.get('welcome.table');
Review Comment:
to clarify, I'm advocating for consolidating these into two component files:
a WelcomeTop component, applied to `welcome.banner`, containing any
components inserted at the top without replacing the homepage (Message and
Banner)
and a HomeReplacement component, applied to `welcome.main.replacement`,
containing any components that should replace the regular home page in their
presence (Data and Table)
The components all have their distinct files, but the logic for showing them
or not has to exist in the Preset side of things anyway, so I don't see any
benefit in breaking them out into separate extension points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
