dungdm93 opened a new pull request, #21066: URL: https://github.com/apache/superset/pull/21066
### SUMMARY #20152 Making the `TrinoEngineSpec` derive from the `PrestoEngineSpec` to reusing code. However, underlay driver of [Trino](https://pypi.org/project/trino/) is different from Presto - [PyHive](https://pypi.org/project/PyHive/) which lead to some issues. This PR is rework on that PR by create `PrestoBaseEngineSpec` to share common functions between Presto variants. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS Unit tests ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
