dungdm93 commented on code in PR #21066:
URL: https://github.com/apache/superset/pull/21066#discussion_r953687283
##########
superset/db_engine_specs/trino.py:
##########
@@ -17,36 +17,59 @@
from __future__ import annotations
import logging
-from typing import Any, Dict, List, Optional, TYPE_CHECKING
+from typing import Any, Dict, Optional, TYPE_CHECKING
import simplejson as json
from flask import current_app
-from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.engine.url import URL
from sqlalchemy.orm import Session
+from superset.constants import USER_AGENT
from superset.databases.utils import make_url_safe
from superset.db_engine_specs.base import BaseEngineSpec
-from superset.db_engine_specs.presto import PrestoEngineSpec
+from superset.db_engine_specs.presto import PrestoBaseEngineSpec
from superset.models.sql_lab import Query
from superset.utils import core as utils
if TYPE_CHECKING:
from superset.models.core import Database
try:
- from trino.dbapi import Cursor # pylint: disable=unused-import
+ from trino.dbapi import Cursor
except ImportError:
pass
logger = logging.getLogger(__name__)
-class TrinoEngineSpec(PrestoEngineSpec):
+class TrinoEngineSpec(PrestoBaseEngineSpec):
engine = "trino"
- engine_aliases = {"trinonative"} # Required for backwards compatibility.
Review Comment:
`trinonative` in `setup.py` already removed since #20152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
