dungdm93 commented on code in PR #21066:
URL: https://github.com/apache/superset/pull/21066#discussion_r953679441
##########
superset/db_engine_specs/trino.py:
##########
@@ -89,32 +113,6 @@ def get_url_for_impersonation(
def get_allow_cost_estimate(cls, extra: Dict[str, Any]) -> bool:
return True
- @classmethod
- def get_table_names(
- cls,
- database: Database,
- inspector: Inspector,
- schema: Optional[str],
- ) -> List[str]:
- return BaseEngineSpec.get_table_names(
- database=database,
- inspector=inspector,
- schema=schema,
- )
-
- @classmethod
- def get_view_names(
- cls,
- database: Database,
- inspector: Inspector,
- schema: Optional[str],
- ) -> List[str]:
- return BaseEngineSpec.get_view_names(
- database=database,
- inspector=inspector,
- schema=schema,
- )
-
Review Comment:
`has_implicit_cancel` is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
